refactor: Add AlignedBytes types
#19308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coastalwhite
requested review from
ritchie46,
orlp and
c-peters
as code owners
github-actions
bot
added
internal
coastalwhite
force-pushed
the
refactor/size-alignment-types
branch
from
e2271e4
to
06b28f9
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #19308 +/- ##
==========================================
- Coverage 80.03% 80.01% -0.03%
==========================================
Files 1528 1532 +4
Lines 209819 210162 +343
Branches 2419 2434 +15
==========================================
+ Hits 167932 168159 +227
- Misses 41336 41448 +112
- Partials 551 555 +4 ☔ View full report in Codecov by Sentry. |
orlp
requested changes
Oct 18, 2024
There was a problem hiding this comment.
Just 'requesting changes' so I can take a good look monday without @ritchie46 merging this in the meantime 😅
This adds types that arrow `NativeType`s can cast to which can help to reduce monomorphizations. This also adds the support to `SharedStorage` to keep use a type with a stricter size and alignment constraint as `BackingStore` without memcopying. fyi @orlp
orlp
force-pushed
the
refactor/size-alignment-types
branch
from
e387dec
to
44f0690
Compare
|
@orlp are there still objections to this getting merged? |
|
@coastalwhite Nope, I pushed my changes and separated the stuff I wanted to separate into a different PR. |
orlp
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds types that arrow
NativeTypes can cast to which can help to reduce monomorphizations. This also adds the support toSharedStorageto keep use a type with a stricter size and alignment constraint asBackingStorewithout memcopying.fyi @orlp